Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python2 Compatibility #40

Closed
nipunn1313 opened this issue Sep 16, 2020 · 6 comments
Closed

Drop Python2 Compatibility #40

nipunn1313 opened this issue Sep 16, 2020 · 6 comments

Comments

@nipunn1313
Copy link
Contributor

Inline the mypy annotations
Remove reference to six library

We should wait until python2 end-of-lifes before completing this task!

@joshuawarner32
Copy link

Isn't python2 already EOL'd? https://www.python.org/doc/sunset-python-2/

@nipunn1313
Copy link
Contributor Author

ah whoops! I somehow (incorrectly) thought it EOL'd at the end of the year. Thanks for the clarification.
I suppose then the last remaining blocker is to make sure DBX internal usage is all py3!

@flying-sheep
Copy link

The pb-jelly-gen readme also still talks about a “python2 script”: https://github.com/dropbox/pb-jelly/blob/master/pb-jelly-gen/README.md

@nipunn1313
Copy link
Contributor Author

Thanks for pointing that out. I believe that reference has been removed now.

@nipunn1313
Copy link
Contributor Author

DBX internal usage is now all py3 - so we can do this! I think we should wait until we get CI set up (#43) - but otherwise looking good

@nipunn1313
Copy link
Contributor Author

This is done with #64 and #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants