Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Swift 4.0 #102

Merged
merged 7 commits into from
Jan 23, 2018
Merged

Upgrade to Swift 4.0 #102

merged 7 commits into from
Jan 23, 2018

Conversation

alanjrogers
Copy link
Contributor

@alanjrogers alanjrogers commented Jan 17, 2018

Upgrades Pilot to Swift 4.

  • Removed now unneeded if swift > 3.2 and swift > 4 conditional compiler checks.
  • Had to change PlatformLayoutPriority to Float on macOS since the typealias to NSLayoutConstraint.LayoutPriorty was causing the compiler to crash.

It crashes the compiler :(
@alanjrogers alanjrogers changed the title [WIP] Upgrading to Swift 4.0 Upgrade to Swift 4.0 Jan 21, 2018
Copy link
Contributor

@danielrhammond danielrhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alanjrogers
Copy link
Contributor Author

@danielrhammond Can you hit merge (I'm not authorised :(

@danielrhammond
Copy link
Contributor

@alanjrogers yeah i was going to wait for the ci to run but looks like the only changes since the last time it succeeded are very obviously benign so will go ahead

@danielrhammond danielrhammond merged commit 705dcdb into master Jan 23, 2018
@danielrhammond danielrhammond deleted the swift4 branch January 23, 2018 01:28
@alanjrogers
Copy link
Contributor Author

@alanjrogers yeah i was going to wait for the ci to run but looks like the only changes since the last time it succeeded are very obviously benign so will go ahead

Thanks! yeah it looks like Travis is slow for some annoying reason :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants