Delay applying new state to currentCollection #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since state was being immediately applied to CollectionViewModelDataSource's currentCollection it would result in observers of CollectionViewModelDataSource to get the post-update sections if they queried during `.willUpdateItems`, this is a pretty bad breach of that api contract but thankfully diff endine has its own copy of the sections so wasn't effected.
|
Wanted to write some tests for this but it got super messy fast due to collection view model datasource's interaction with {NS,UI}CollectionView. Here's my first take at it, want to spend some more time trying to come up with a better solution but want to separate that from landing this fix. |
wkiefer
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since state was being immediately applied to CollectionViewModelDataSource's currentCollection it would result in observers of CollectionViewModelDataSource to get the post-update sections if they queried during
.willUpdateItems, this is a pretty bad breach of that api contract but thankfully diff endine has its own copy of the sections so wasn't effected.