Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstrings #110

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Fix docstrings #110

merged 1 commit into from
Mar 19, 2021

Conversation

gotcha
Copy link
Contributor

@gotcha gotcha commented Mar 19, 2021

start and stop were mixed

gvanrossum
gvanrossum approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Alas, I no longer have access to merge PRs on this repo.

@gvanrossum
Copy link
Contributor

PS. Ignore the failing test. We should remove 3.5(.1) from the supported / tested Python versions.

@JukkaL JukkaL merged commit 1e7ddf0 into dropbox:master Mar 19, 2021
@jugmac00 jugmac00 mentioned this pull request Mar 27, 2021
Closed
@cclauss cclauss mentioned this pull request Apr 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gotcha @gvanrossum @JukkaL