Fix record types in IdpData #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, dialyzer objected to the use of data from these fields in a call to update the record. Luckily, :esaml provides types for these records.
|
|
k-cross
approved these changes
Apr 19, 2024
|
thanks for the type updates |
|
Would it be possible to have a hex release with these fixes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there 👋🏼
Previously, dialyzer objected to the use of data from these two fields in a call to update the record (for example,
Esaml.esaml_sp(sp, ...). This wasn't obvious because callers tend to pull%IdpData{}structs out ofconn.private, without any assertion that the data should conform toIdpData.t(). Warnings would only appear if someone attempted to modify data straight out ofHelper.get_idp/1or something similar.Luckily,
:esamlprovides types for these records.