Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty string literal in Swift code #172

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Conversation

xuyanke
Copy link
Contributor

@xuyanke xuyanke commented Sep 3, 2020

Fixed empty string literal in generated Swift code and included module imports in generated routes files.

@xuyanke xuyanke force-pushed the fix_swift_empty_string branch 3 times, most recently from 8c8d6f9 to 1e36d44 Compare September 4, 2020 22:38
@xuyanke
Copy link
Contributor Author

xuyanke commented Sep 4, 2020

CI build seems failed due to a lot of W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from) warnings not related to changes in this PR.

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #172 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   50.81%   50.80%   -0.02%     
==========================================
  Files          37       37              
  Lines        8318     8320       +2     
  Branches     1769     1770       +1     
==========================================
  Hits         4227     4227              
- Misses       3778     3780       +2     
  Partials      313      313              
Flag Coverage Δ
#unit 50.80% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/backends/swift_client.py 0.00% <0.00%> (ø)
stone/backends/swift_helpers.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc591e...1d94c71. Read the comment docs.

Xuyan Ke added 2 commits September 21, 2020 10:26
Replaced single-quotes Unicode empty string with double-quotes string.
@xuyanke
Copy link
Contributor Author

xuyanke commented Sep 21, 2020

Thank you @connorworley for approving this PR. For some reason I don't have the permission to merge PRs in this repo anymore. Could you help merging this?

@connorworley connorworley merged commit d533fcd into master Sep 21, 2020
@connorworley connorworley deleted the fix_swift_empty_string branch September 21, 2020 22:10
@connorworley connorworley mentioned this pull request Sep 21, 2020
@connorworley
Copy link
Contributor

This will be released as v2.2.2. Let me know if you need help vendoring it internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants