Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS and TS routes for null parameters #186

Merged
merged 5 commits into from Oct 5, 2020

Conversation

rogebrd
Copy link
Contributor

@rogebrd rogebrd commented Oct 5, 2020

  • Fix for (JS #41)
  • Update route to not have arg when there is no parameter
  • Update comments to also not contain arg when no parameter
  • Update tests for both clients

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

- Fix for ([JS #41](dropbox/dropbox-sdk-js#41))
- Update route to not have `arg` when there is no parameter
- Update comments to also not contain `arg` when no parameter
- Update tests for both clients
Copy link
Contributor

@aelawson aelawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to update the version (this is also a breaking change so should should be major version bump).

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #186 into master will increase coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   50.81%   50.86%   +0.04%     
==========================================
  Files          37       37              
  Lines        8322     8334      +12     
  Branches     1770     1776       +6     
==========================================
+ Hits         4229     4239      +10     
- Misses       3780     3782       +2     
  Partials      313      313              
Flag Coverage Δ
#unit 50.86% <83.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/backends/js_client.py 76.11% <75.00%> (-0.16%) ⬇️
stone/backends/tsd_client.py 62.12% <100.00%> (+2.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba8974...9b6fe0c. Read the comment docs.

@rogebrd rogebrd merged commit 07c4d19 into master Oct 5, 2020
@rogebrd rogebrd deleted the fix_void_js_ts_parameters branch October 5, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants