Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoding intput files as utf8 after reading #195

Merged
merged 1 commit into from Oct 27, 2020

Conversation

shizam
Copy link
Contributor

@shizam shizam commented Oct 26, 2020

Fixing a problem where utf-8 characters in the stone file break parsing.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   51.17%   51.17%           
=======================================
  Files          37       37           
  Lines        8351     8351           
  Branches     1781     1781           
=======================================
  Hits         4274     4274           
  Misses       3757     3757           
  Partials      320      320           
Flag Coverage Δ
#unit 51.17% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/cli.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ece6e...0ea697f. Read the comment docs.

@greg-db
Copy link
Contributor

greg-db commented Oct 27, 2020

Thanks!

@karandeep-johar karandeep-johar merged commit 4a9a1c8 into dropbox:master Oct 27, 2020
karandeep-johar added a commit that referenced this pull request Oct 27, 2020
karandeep-johar added a commit that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants