Add ability to dynamically import namespaces from types in the tsd client #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 51.72% 51.64% -0.08%
==========================================
Files 37 37
Lines 8370 8390 +20
Branches 1786 1789 +3
==========================================
+ Hits 4329 4333 +4
- Misses 3727 3743 +16
Partials 314 314
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eugeneyche
approved these changes
May 17, 2021
| import_template_string = self.args.import_template_string | ||
| import_from_file = self.args.types_file | ||
| # /*IMPORT*/ | ||
| i_match = re.search("/\\*%s\\*/" % (import_template_string), template) |
There was a problem hiding this comment.
LOL this seems super manual, but I see it used in other places. Have we considered using an actual template language library?
stone/backends/tsd_client.py
Outdated
| '--types-file', | ||
| type=str, | ||
| default='', | ||
| help=('If using the --import-namespaces flag, this if the file that contains ' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General Contributing
Is This a Code Change?
Validation
tox?