Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run pyupgrade and optimize imports in pycharm #312

Merged
merged 5 commits into from Jul 31, 2023
Merged

run pyupgrade and optimize imports in pycharm #312

merged 5 commits into from Jul 31, 2023

Conversation

devPalacio
Copy link
Contributor

@devPalacio devPalacio commented Jul 20, 2023

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #312 (d274aa9) into main (02feff3) will decrease coverage by 0.02%.
The diff coverage is 66.50%.

❗ Current head d274aa9 differs from pull request most recent head a6c7fcb. Consider uploading reports for the commit a6c7fcb to get more accurate results

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   51.94%   51.93%   -0.02%     
==========================================
  Files          37       37              
  Lines        8464     8415      -49     
  Branches     1811     1807       -4     
==========================================
- Hits         4397     4370      -27     
+ Misses       3750     3729      -21     
+ Partials      317      316       -1     
Flag Coverage Δ
unit 51.93% <66.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/backends/helpers.py 86.36% <ø> (-0.60%) ⬇️
stone/backends/js_types.py 0.00% <0.00%> (ø)
stone/backends/obj_c.py 0.00% <0.00%> (ø)
stone/backends/obj_c_client.py 0.00% <0.00%> (ø)
stone/backends/obj_c_helpers.py 0.00% <ø> (ø)
stone/backends/obj_c_types.py 0.00% <0.00%> (ø)
stone/backends/python_client.py 46.26% <ø> (-0.20%) ⬇️
stone/backends/python_types.py 35.86% <0.00%> (-0.12%) ⬇️
stone/backends/swift.py 0.00% <0.00%> (ø)
stone/backends/swift_client.py 0.00% <0.00%> (ø)
... and 24 more

test/backend_test_util.py Outdated Show resolved Hide resolved
@@ -12,7 +10,7 @@
from unittest.mock import Mock
except ImportError:
# See https://github.com/python/mypy/issues/1153#issuecomment-253842414
from mock import Mock # type: ignore
from unittest.mock import Mock # type: ignore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's another one

@julianlocke julianlocke requested a review from a team July 24, 2023 21:52
@julianlocke julianlocke merged commit 7dc5d96 into main Jul 31, 2023
10 checks passed
@julianlocke julianlocke deleted the pyupgrade branch July 31, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants