Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement subtract button on else clauses #200

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Jun 26, 2017

  • Subtract button added to else clauses in JavaScript
    • When pressed, the button removes the final else or else if clause and the statements within. (Undo will bring back anything that was deleted). If we find that we don't like this behavior, we can modify the button handling to try to extract only the } else { or } else if (__) {, effectively moving the code within the final clause up into the previous clause.

subtractelseclauses

Copy link

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davidsbailey davidsbailey changed the base branch from update-cdo-from-master to code-dot-org June 26, 2017 18:37
@davidsbailey
Copy link

I'm going to go ahead and merge this for you so that I can prepare to pull it into the code-dot-org repo.

@davidsbailey davidsbailey merged commit 4cb2bce into code-dot-org Jun 26, 2017
@davidsbailey davidsbailey deleted the subtract_button_on_else_clauses branch June 26, 2017 18:54
davidsbailey added a commit to code-dot-org/code-dot-org that referenced this pull request Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants