DROOP-1034: Replaced multiple item link field with single item link field #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-droptica
reviewed
Dec 20, 2023
| @@ -0,0 +1,18 @@ | |||
| langcode: en | |||
There was a problem hiding this comment.
If the field with a universal name and purpose has been created then the storage config should be in a global location, like for the field_d_cta_link. Let's move it to the d_p modules/feature.
There was a problem hiding this comment.
I've moved this file to the correct folder.
js-droptica
approved these changes
Dec 21, 2023
js-droptica
deleted the
feature/DROOP-1034-Disable-multiple-urls-for-a-single-carousel-item
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.