Simplify release signing #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keyname from maven settings, prompt for password
Summary:
=======
GPG Key name should be dictated by the local settings of the deployer, not by the maven pom.
We can let gpg prompt for the key's password.
This will simplify release/deploy arguments.
Actions:
=======
* Remove the hard-coded gpg keyname from the pom.
* Remove references to ${gpg.passphrase} from the pom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyname from maven settings, prompt for password
Summary:
GPG Key name should be dictated by the local settings of the deployer, not by the maven pom.
We can let gpg prompt for the key's password.
This will simplify release/deploy arguments.
Actions: