Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic Management from Configuration #17

Closed
OneCricketeer opened this issue Jun 14, 2019 · 2 comments
Closed

Topic Management from Configuration #17

OneCricketeer opened this issue Jun 14, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@OneCricketeer
Copy link
Contributor

OneCricketeer commented Jun 14, 2019

Now that AdminClient was added, I suggest adding a way that, during the lifecycle startup, then topics are created if they don't already exist.

Relevant methods:

Configuration suggestion

topics:
  - name: foo
    partitions: 3
    replicationFactor: 3
  # topic with additional configuration
  - name: bar
    partitions: 1
    replicationFactor: 5
    config:
      cleanup.policy: compact

Additionally, would be nice to have a healthcheck that verifies topic existance + configuration details, but that can be future issue.

@natalie-zamani natalie-zamani added enhancement New feature or request help wanted Extra attention is needed labels Jun 14, 2019
@natalie-zamani
Copy link
Member

Hey @Cricket007, thanks for another good suggestion. :) Would you have any interest in taking a crack at contributing?

@OneCricketeer
Copy link
Contributor Author

Ref #19

Got the YAML parser down, I think. Not sure how the Discoverable interface works, but doesn't seem to pick up that Factory class.

Also, since the AdminClient is required to create topics, I believe those would go together as part of a Bundle rather than a Factory? Not too familiar with Dropwizard terms here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants