Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.dropwizard.jetty.MutableServletContextHandler.requests metrics not accurate for async requests? #2079

Closed
raynorchenfr opened this issue Jun 16, 2017 · 2 comments

Comments

@raynorchenfr
Copy link

I am using dropwizard 1.0.2, and when trying to export some metrics on RESTful request endpoints.

One of the metrics used is io.dropwizard.jetty.MutableServletContextHandler.requests.

The metrics seemed correct for synchronously handled requests. But for requests that are handled asynchronously, the number reported is almost always around 1.5e9 (nano seconds), which is around 1.5 seconds, even if the responses got returned relatively quickly. Is there a way to configure/fix this?

Thanks in advance.

@nickbabcock
Copy link
Contributor

This was fixed in dropwizard/metrics#1074 which landed in metrics 3.2.0, which is bundled in Dropwizard 1.1.0, so you will have to upgrade

@raynorchenfr
Copy link
Author

@nickbabcock Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants