Exclude javax.el and jakarta.el-api, using glassfish jakarta.el instead #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes duplicate classes between the 3 jars Fixes dropwizard#2739
|
For reference, more information is at https://eclipse-foundation.blog/2018/02/26/and-the-name-is/ |
|
Does jakarta.el-api still need to be excluded? This is not correct in DW 4.0.1 the glassfish jakarta.el implementation jar includes all the classes from the jakarta.el-api And it does not get included as a transitive dependency in some scenarios with DW 4.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes duplicate classes between the 3 jars
Fixes #2739
Problem:
jakarta jars are replacing javax jars, so should depend on that instead of javax. Furthermore, the glassfish jakarta.el implementation jar includes all the classes from the jakarta.el-api jar (see jakartaee/expression-language#32), so should only depend on the implementation jar.
Solution:
depend on org.glassfish:jakarta-el, and exclude the other 2 jars