-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics jcache #1010
Add metrics jcache #1010
Conversation
* read them from JCache CacheStatisticsMBean * pair programmed with Henri Tremblay
… are monitoring to already be available
<module>metrics-ganglia</module> | ||
<module>metrics-graphite</module> | ||
<module>metrics-httpclient</module> | ||
<module>metrics-httpasyncclient</module> | ||
<module>metrics-jcache</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe, not sure what this commit is bringing :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is putting jcache at the right place. All modules are in alphabetical order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ! ok then ! good catch
Hi. I know the contributors of this project are probably overloaded but I would like a head's up. I want to know if you are ok for adding a jcache module? When this PR can then be processed if a different matter. |
@anthonydahanne and @henri-tremblay, Sorry to for the late response. I think this is a very fine module. The JCache specification has a JSR and supported by many caching libraries, so it makes sense to include and support it as one of the main modules. The implementation is rather concise, and I don't see downsides of merging it. Thank you and Terracotta for contributing it. |
Awesome. Thanks |
Hi. When do you think the next release will be performed? |
Hi @henri-tremblay, I recently merged a bunch of pending pull requests to the 3.2 branch, and last week there were not so much activity on the project, so I think it's time to prepare a release. I will try to reach out to @ryantenney about it this week (he has the deploy rights to the |
This is a JCache module for metrics. It should works with any JCache compatible cache and was tested with Ehcache inside JHipster.
It was implemented by @anthonydahanne and I from Terracotta