Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics jcache #1010

Merged
Merged

Conversation

@henri-tremblay
Copy link
Contributor

@henri-tremblay henri-tremblay commented Oct 3, 2016

This is a JCache module for metrics. It should works with any JCache compatible cache and was tested with Ehcache inside JHipster.

It was implemented by @anthonydahanne and I from Terracotta

<module>metrics-ganglia</module>
<module>metrics-graphite</module>
<module>metrics-httpclient</module>
<module>metrics-httpasyncclient</module>
<module>metrics-jcache</module>

This comment has been minimized.

@anthonydahanne

anthonydahanne Oct 4, 2016
Contributor

hehe, not sure what this commit is bringing :-)

This comment has been minimized.

@henri-tremblay

henri-tremblay Oct 4, 2016
Author Contributor

It is putting jcache at the right place. All modules are in alphabetical order

This comment has been minimized.

@anthonydahanne

anthonydahanne Oct 4, 2016
Contributor

ah ! ok then ! good catch

@henri-tremblay
Copy link
Contributor Author

@henri-tremblay henri-tremblay commented Oct 9, 2016

Hi. I know the contributors of this project are probably overloaded but I would like a head's up.

I want to know if you are ok for adding a jcache module? When this PR can then be processed if a different matter.

@jplock jplock added this to the 3.2.0 milestone Oct 26, 2016
@arteam
Copy link
Member

@arteam arteam commented Jan 5, 2017

@anthonydahanne and @henri-tremblay,

Sorry to for the late response. I think this is a very fine module. The JCache specification has a JSR and supported by many caching libraries, so it makes sense to include and support it as one of the main modules. The implementation is rather concise, and I don't see downsides of merging it. Thank you and Terracotta for contributing it.

@arteam arteam merged commit 18866d2 into dropwizard:3.2-development Jan 5, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@henri-tremblay
Copy link
Contributor Author

@henri-tremblay henri-tremblay commented Jan 5, 2017

Awesome. Thanks

@henri-tremblay henri-tremblay deleted the henri-tremblay:add_metrics_jcache branch Jan 5, 2017
@henri-tremblay
Copy link
Contributor Author

@henri-tremblay henri-tremblay commented Jan 23, 2017

Hi. When do you think the next release will be performed?

@arteam
Copy link
Member

@arteam arteam commented Jan 23, 2017

Hi @henri-tremblay, I recently merged a bunch of pending pull requests to the 3.2 branch, and last week there were not so much activity on the project, so I think it's time to prepare a release. I will try to reach out to @ryantenney about it this week (he has the deploy rights to the io.dropwizard.metrics namespace in the Maven Central repository)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants