Move closing DatagramChannel to the close method
#1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can align `GraphiteUDP` with the TCP based `Graphite` and close the socket in the `close` method instead of the connect method. The close method will be invoked every time after a portion of metrics has been sent, so we can close the socket there. We also do not need to call the method `isConnected` during sending metrics because the socket is opened right before sending data, so it can't be closed by timeout.
ryantenney
previously approved these changes
Feb 19, 2017
|
I think I understand, since we now always close the socket after reporting a batch of metrics, it doesn't make sense to wait for the next connect call to close the DatagramSocket? |
ryantenney
approved these changes
Feb 20, 2017
|
Right. The |
arteam
added a commit
that referenced
this pull request
Mar 10, 2017
We can align `GraphiteUDP` with the TCP based `Graphite` and close the socket in the `close` method instead of the connect method. The close method will be invoked every time after a portion of metrics has been sent, so we can close the socket there. We also do not need to call the method `isConnected` during sending metrics because the socket is opened right before sending data, so it can't be closed by timeout. (cherry picked from commit d18b6ab)
arteam
added a commit
that referenced
this pull request
Mar 10, 2017
We can align `GraphiteUDP` with the TCP based `Graphite` and close the socket in the `close` method instead of the connect method. The close method will be invoked every time after a portion of metrics has been sent, so we can close the socket there. We also do not need to call the method `isConnected` during sending metrics because the socket is opened right before sending data, so it can't be closed by timeout. (cherry picked from commit d18b6ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can align
GraphiteUDPwith the TCP basedGraphiteand close thesocket in the
closemethod instead of the connect method. The closemethod will be invoked every time after a portion of metrics has been
sent, so we can close the socket there. We also do not need to call
the method
isConnectedduring sending metrics because the socket isopened right before sending data, so it can't be closed by timeout.