Improve metrics filter #1193
Merged
Improve metrics filter #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Clock` is already an abstraction over a tick represented by a long value, so it seem superfluous to use a provided for a class which doesn't have any state and doesn't change.
So we its creation doesn't carry all fields of `InstrumentedResourceMethodApplicationListener` and we explicitly set fields its state.
To be more much more clear what event handlers do. Otherwise, they reuse the common variable and the correct behaviour depends on the sequence in which Jersey produces events.
We should not guess whether to include filter metrics based on the metric name. Since tracking of filter times is a new feature, it should be enabled explicitly for users who want it. For other users, the process of migrating to the new instrumented listener should be backward-compatible.
arteam
added a commit
that referenced
this pull request
Sep 15, 2017
* Don't use a ClockProvider `Clock` is already an abstraction over a tick represented by a long value, so it seem superfluous to use a provided for a class which doesn't have any state and doesn't change. * Make TimerRequestEventListener a static inner class So we its creation doesn't carry all fields of `InstrumentedResourceMethodApplicationListener` and we explicitly set fields its state. * Remove the superfluous method "key" * Split contexts to several variables To be more much more clear what event handlers do. Otherwise, they reuse the common variable and the correct behaviour depends on the sequence in which Jersey produces events. * Add explicit flag to control tracking filters We should not guess whether to include filter metrics based on the metric name. Since tracking of filter times is a new feature, it should be enabled explicitly for users who want it. For other users, the process of migrating to the new instrumented listener should be backward-compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement to #1118.
We should not guess whether to include filter metrics based on the
metric name. Since tracking of filter times is a new feature, it
should be enabled explicitly for users who want it. For other users,
the process of migrating to the new instrumented listener should be
backward-compatible.
To be more much more clear what event handlers do. Otherwise, they
reuse the common variable and the correct behaviour depends on the
sequence in which Jersey produces events.
Remove the superfluous method "key"
Make TimerRequestEventListener a static inner class
So we its creation doesn't carry all fields of
InstrumentedResourceMethodApplicationListenerand we explicitlyset fields its state.
Don't use a ClockProvider
Clockis already an abstraction over a tick represented by a long value,so it seem superfluous to use a provided for a class which doesn't have
any state and doesn't change.