Unnecessary clear operation removal
#1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, what do you think about replacing of |
|
LGTM, I think that's justified. I'm still reluctant to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Recently I've discussed
ChunkedAssociativeArrayimplementation with my colleague and he had noticed thatChunkedAssociativeArraycontains whole bunch of complicated codeclear(long startKey, long endKey)to support one supper rare case of long overflow, that can happen only after 1 year after class loading. And even then, it is not so helpful, we will remove almost all values.So I've decided to simplify handling of this case 馃槃 .