New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary `clear` operation removal #1211

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@storozhukBM
Contributor

storozhukBM commented Oct 6, 2017

Hi
Recently I've discussed ChunkedAssociativeArray implementation with my colleague and he had noticed that ChunkedAssociativeArray contains whole bunch of complicated code clear(long startKey, long endKey) to support one supper rare case of long overflow, that can happen only after 1 year after class loading. And even then, it is not so helpful, we will remove almost all values.
So I've decided to simplify handling of this case 馃槃 .

@storozhukBM

This comment has been minimized.

Contributor

storozhukBM commented Oct 6, 2017

Also, what do you think about replacing of SlidingTimeWindowReservoir by this SlidingTimeWindowArrayReservoir in 4.0 branch?

@arteam arteam merged commit 91034f7 into dropwizard:4.0-development Nov 28, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arteam

This comment has been minimized.

Member

arteam commented Nov 28, 2017

LGTM, I think that's justified. I'm still reluctant to make SlidingTimeWindowArrayReservoir as default, though.

@arteam arteam added the improvement label Dec 24, 2017

@arteam arteam added this to the 4.0.0 milestone Dec 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment