Support metrics on JDK9 #1236
Merged
Support metrics on JDK9 #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take into account the differences in the output of string representations of dates in JDK8 and JDK9. See: http://mail.openjdk.java.net/pipermail/jdk9-dev/2017-April/005732.html
Remove reflection hacks and access `UnixOperatingSystemMXBean` directly. Reflection hacks don't work in JDK9 anymore, and the `UnixOperatingSystemMXBean` is exported since JDK8, so we can directly check the type of the system bean and calculate the ration of open file descriptors.
We need to add the `java.xml.bind` module to give JCache access to JAXB.
Makes sure that metrics can be compiled and run on JDK9 without issues.
arteam
force-pushed
the
4.0-development
branch
from
ee6fe82
to
2fb8f7d
Compare
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Nov 3, 2019
### What changes were proposed in this pull request? Update the version of dropwizard metrics that Spark uses for metrics to 4.1.x, from 3.2.x. ### Why are the changes needed? This helps JDK 9+ support, per for example dropwizard/metrics#1236 ### Does this PR introduce any user-facing change? No, although downstream users with custom metrics may be affected. ### How was this patch tested? Existing tests. Closes #26332 from srowen/SPARK-29674. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues with running metrics on JDK8 and JDK9:
ConsoleReporterFileDescriptorRatioGauge, so it doesn't use reflectionjava.xml.bindmodule to the JCache tests, so it can access JAXB on JDK9