New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metrics on JDK9 #1236

merged 5 commits into from Dec 23, 2017


None yet
1 participant

arteam commented Dec 22, 2017

This fixes the issues with running metrics on JDK8 and JDK9:

  • Fix date formatting differences between JDK8 and JDK9 in ConsoleReporter
  • Fix FileDescriptorRatioGauge, so it doesn't use reflection
  • Add the java.xml.bind module to the JCache tests, so it can access JAXB on JDK9
  • Add a JDK9 profile, so we check that we can compile metrics in JDK9
  • Finally, it adds JDK9 to the test matrix on Travis CI.

arteam added some commits Dec 22, 2017

Fix ConsoleReporterTest on JDK9
Take into account the differences in the output of string representations
of dates in JDK8 and JDK9.

Support FileDescriptorRatioGauge on JDK8/JDK9
Remove reflection hacks and access `UnixOperatingSystemMXBean` directly.
Reflection hacks don't work in JDK9 anymore, and the `UnixOperatingSystemMXBean`
is exported since JDK8, so we can directly check the type of the system bean
and calculate the ration of open file descriptors.
Support running tests for JCache on JDK9
We need to add the `java.xml.bind` module to give JCache access to
Run tests on JDK8 and JDK9 on Travis CI
Makes sure that metrics can be compiled and run on JDK9 without issues.

@arteam arteam force-pushed the 4.0-development branch from ee6fe82 to 2fb8f7d Dec 23, 2017

@arteam arteam merged commit f082dcb into 4.0-development Dec 23, 2017

5 checks passed

codeclimate All good!
continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@arteam arteam deleted the jdk9 branch Dec 23, 2017

@arteam arteam added the improvement label Dec 24, 2017

@arteam arteam added this to the 4.0.0 milestone Dec 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment