Add Bill of Materials for Metrics #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics is a multi-module project with a lot of interproject dependencies. Also there's a lot of Metrics version in the wild (3.1.2, 3.1.5, 3.2.3, 3.2.5, 4.0.0). Many projects often depend on metrics as a 3rd-party dependency. It would be nice if Metrics users could specify the metrics version for all dependencies consistently via a BOM dependency.
scottcarey
reviewed
Jul 19, 2019
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| <version>${http-client.version}</version> |
There was a problem hiding this comment.
this bom absolutely should not have included things that are not part of the build (dropwizard stuff)
Including all the third party things makes this inconsumable for external users if even one of those things clashes with another library, even if we aren't using the submodule that depends on it.
This pom should have been to help external users manage the metrics dependencies, not all transitive ones.
Useless. I'll have to copy paste the top part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics is a multi-module project with a lot of interproject dependencies. Also there's a lot of Metrics version in the wild (3.1.2, 3.1.5, 3.2.3, 3.2.5, 4.0.0). Many projects often depend on metrics as
a 3rd-party dependency. It would be nice if Metrics users could specify a metrics version for all dependencies consistently via a BOM dependency without manual twiddling with excludes.
Fixes #1169