Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bill of Materials for Metrics #1239

Merged
merged 1 commit into from Dec 23, 2017
Merged

Add Bill of Materials for Metrics #1239

merged 1 commit into from Dec 23, 2017

Conversation

@arteam
Copy link
Member

@arteam arteam commented Dec 23, 2017

Metrics is a multi-module project with a lot of interproject dependencies. Also there's a lot of Metrics version in the wild (3.1.2, 3.1.5, 3.2.3, 3.2.5, 4.0.0). Many projects often depend on metrics as
a 3rd-party dependency. It would be nice if Metrics users could specify a metrics version for all dependencies consistently via a BOM dependency without manual twiddling with excludes.

Fixes #1169

Metrics is a multi-module project with a lot of interproject dependencies.
Also there's a lot of Metrics version in the wild (3.1.2, 3.1.5,
3.2.3, 3.2.5, 4.0.0). Many projects often depend on metrics as
a 3rd-party dependency. It would be nice if Metrics users could specify
the metrics version for all dependencies consistently via a BOM
dependency.
@arteam arteam force-pushed the metrics-bom branch from bc58106 to 5265127 Dec 23, 2017
@arteam arteam merged commit 2a67b9c into 4.0-development Dec 23, 2017
5 checks passed
5 checks passed
codeclimate All good!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@arteam arteam deleted the metrics-bom branch Dec 23, 2017
@arteam arteam added this to the 4.0.0 milestone Dec 24, 2017
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
<version>${http-client.version}</version>

This comment has been minimized.

@scottcarey

scottcarey Jul 19, 2019

this bom absolutely should not have included things that are not part of the build (dropwizard stuff)

Including all the third party things makes this inconsumable for external users if even one of those things clashes with another library, even if we aren't using the submodule that depends on it.

This pom should have been to help external users manage the metrics dependencies, not all transitive ones.

Useless. I'll have to copy paste the top part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants