Add group and type to annotations #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 8, 2012 08:56
Metered, Timed, ExceptionMetered, and Guage have all been updated to support two new attributes on the annotation: - group - if omitted, defaults to the package name (as before) - name - if omitted, defaults to simple class name (as before) This involved changing the Guice annotation support code to check for these attributes as well as the jersey dispatcher code for the same reason. In order to make the behavior consistent across the two, the methods for choosing the appropriate value have been placed into MetricName as static methods.
also cleaned up some minor typos and extraneous imports
Metered, Timed, ExceptionMetered, and Gauge have all been updated to support two new attributes on the annotation: - group - if omitted, defaults to the package name (as before) - type - if omitted, defaults to simple class name (as before) This involved changing the guice annotation support code to check for these attributes as well as the jersey dispatcher code for the same reason. In order to make the behavior consistent across the two, the methods for choosing the appropriate value have been placed into MetricName as static methods. Also clean up a couple tests so they pass on windows.
codahale
added a commit
that referenced
this pull request
Feb 26, 2012
Add group and type to annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds two attributes to the various metric annotations:
Both are optional and the behavior if they are omitted should be the same as before. The main objective was to simplify the names that ultimately make their way into graphite. Sorry for the three commits. I originally had this in a different server and pull it into this one.