ExponentiallyDecayingReservoirTest improvements #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaochuanyu
pushed a commit
to xiaochuanyu/metrics
that referenced
this pull request
Jun 16, 2020
Improves some of the comments and test parameters in `com.codahale.metrics.ExponentiallyDecayingReservoirTest`. I think that dropwizard#1582 can be closed after this is merged as the implementation is correct and statistical error is expected. The increase of alpha value for `longPeriodsOfInactivityShouldNotCorruptSamplingState` should eliminate/reduce failure. I couldn't recrate this value.
xiaochuanyu
pushed a commit
to xiaochuanyu/metrics
that referenced
this pull request
Jun 16, 2020
Improves some of the comments and test parameters in `com.codahale.metrics.ExponentiallyDecayingReservoirTest`. I think that dropwizard#1582 can be closed after this is merged as the implementation is correct and statistical error is expected. The increase of alpha value for `longPeriodsOfInactivityShouldNotCorruptSamplingState` should eliminate/reduce failure. I couldn't recrate this value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves some of the comments and test parameters in
com.codahale.metrics.ExponentiallyDecayingReservoirTest.I think that #1582 can be closed after this is merged as the implementation is correct and statistical error is expected.
The increase of alpha value for
longPeriodsOfInactivityShouldNotCorruptSamplingStateshould eliminate/reduce failure. I couldn't recrate this value.