-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SettableGauge interface and an implementation #1607
Conversation
@joschi I've made this new PR to target @the-thing I've addressed the comments from the original PR in 9fe9105 here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The name of the default implementation might not suit some people, because the existing naming convention favours "Default" prefix such as com.codahale.metrics.jdbi3.strategies.DefaultNameStrategy
or com.codahale.metrics.jmx.DefaultObjectNameFactory
.
Merged in f4d84b6. |
This PR was re-made from #1599 to change source (and target branch).
This PR attempts to address #1126.
Example usage: