Provide a common method to stop a reporter #743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e implementation.
tjcelaya
added a commit
to tjcelaya/dropwizard-metrics
that referenced
this pull request
Apr 27, 2018
…obfischer for the initial implementation.
arteam
pushed a commit
that referenced
this pull request
May 1, 2018
…xplicit. (#1307) * Resolves #1305 and reimplements #743. Credit to @obfischer for the initial implementation. * Fix Code Climate check and call out the java.io.Closeable interface in JmxReporter and ScheduledReporter * Incorporate feedback about explicit implements in order to maintain binary compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use multiple reporter and it would be helpfull to have a common method to stop a reporter. This change only changes the
Reporterinterface. AllReporterimplementations provide already astopmethod and also implement theCloseableinterface.