Allow a pluggable strategy for the name of the CSV files that the CsvReporter uses #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(CsvReporter.class); | ||
| private static final Charset UTF_8 = Charset.forName("UTF-8"); | ||
| private static final Charset UTF_8 = Charset.forName( "UTF-8" ); |
There was a problem hiding this comment.
There are a number of lines like this which haven't changed except for the insertion of some spaces. Could you fix these and make sure that all other method invocations don't contain spaces except after commas?
|
Thanks! There's just one issue with formatting, if you can fix that I'll merge this. |
…Reporter uses - fix formatting
|
Great! Formatting should be ok now. |
ryantenney
added a commit
that referenced
this pull request
Nov 2, 2015
Allow a pluggable strategy for the name of the CSV files that the CsvReporter uses
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the naming of the CSV file from the CSV reporter itself. This allows users to come up with their own naming strategy.
Using this code as a base, I have implemented a naming strategy that uses the current date to generate a file per day and allows to keep x days of files. If interested I can also contribute this in a separate pull request.
NOTE: Something went wrong when I tried to fix my username so I had to delete my fork and create a new fork. So #879 is no longer valid. Sorry about that.