Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a pluggable strategy for the name of the CSV files that the CsvReporter uses #882

Merged

Conversation

@wimdeblauwe
Copy link

@wimdeblauwe wimdeblauwe commented Nov 2, 2015

This PR extracts the naming of the CSV file from the CSV reporter itself. This allows users to come up with their own naming strategy.
Using this code as a base, I have implemented a naming strategy that uses the current date to generate a file per day and allows to keep x days of files. If interested I can also contribute this in a separate pull request.

NOTE: Something went wrong when I tried to fix my username so I had to delete my fork and create a new fork. So #879 is no longer valid. Sorry about that.

}
}

private static final Logger LOGGER = LoggerFactory.getLogger(CsvReporter.class);
private static final Charset UTF_8 = Charset.forName("UTF-8");
private static final Charset UTF_8 = Charset.forName( "UTF-8" );
Copy link
Member

@ryantenney ryantenney Nov 2, 2015

There are a number of lines like this which haven't changed except for the insertion of some spaces. Could you fix these and make sure that all other method invocations don't contain spaces except after commas?

@ryantenney
Copy link
Member

@ryantenney ryantenney commented Nov 2, 2015

Thanks! There's just one issue with formatting, if you can fix that I'll merge this.

@wimdeblauwe
Copy link
Author

@wimdeblauwe wimdeblauwe commented Nov 2, 2015

Great! Formatting should be ok now.

ryantenney added a commit that referenced this issue Nov 2, 2015
Allow a pluggable strategy for the name of the CSV files that the CsvReporter uses
@ryantenney ryantenney merged commit 4112b29 into dropwizard:master Nov 2, 2015
1 check passed
@ryantenney
Copy link
Member

@ryantenney ryantenney commented Nov 2, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants