New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a pluggable strategy for the name of the CSV files that the CsvReporter uses #882

Merged
merged 2 commits into from Nov 2, 2015

Conversation

Projects
None yet
2 participants
@wimdeblauwe

wimdeblauwe commented Nov 2, 2015

This PR extracts the naming of the CSV file from the CSV reporter itself. This allows users to come up with their own naming strategy.
Using this code as a base, I have implemented a naming strategy that uses the current date to generate a file per day and allows to keep x days of files. If interested I can also contribute this in a separate pull request.

NOTE: Something went wrong when I tried to fix my username so I had to delete my fork and create a new fork. So #879 is no longer valid. Sorry about that.

@ryantenney

This comment has been minimized.

Show comment
Hide comment
@ryantenney

ryantenney Nov 2, 2015

Member

Thanks! There's just one issue with formatting, if you can fix that I'll merge this.

Member

ryantenney commented Nov 2, 2015

Thanks! There's just one issue with formatting, if you can fix that I'll merge this.

@wimdeblauwe

This comment has been minimized.

Show comment
Hide comment
@wimdeblauwe

wimdeblauwe Nov 2, 2015

Great! Formatting should be ok now.

wimdeblauwe commented Nov 2, 2015

Great! Formatting should be ok now.

ryantenney added a commit that referenced this pull request Nov 2, 2015

Merge pull request #882 from wimdeblauwe/allow-pluggable-csv-filename
Allow a pluggable strategy for the name of the CSV files that the CsvReporter uses

@ryantenney ryantenney merged commit 4112b29 into dropwizard:master Nov 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ryantenney

This comment has been minimized.

Show comment
Hide comment
@ryantenney

ryantenney Nov 2, 2015

Member

Thanks!

Member

ryantenney commented Nov 2, 2015

Thanks!

@wimdeblauwe wimdeblauwe deleted the wimdeblauwe:allow-pluggable-csv-filename branch Nov 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment