Adding the enctype and method now if falling back to default upload.

This also improves the fallback form. #22
dropzone · Feb 6, 2013 · 7f499b6 · 7f499b6
1 parent 18b52e0
commit 7f499b6
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 0 deletions.
diff --git a/downloads/dropzone-amd-module.js b/downloads/dropzone-amd-module.js
@@ -383,6 +383,13 @@ Emitter.prototype.hasListeners = function(event){
       fields = o("<div class=\"fallback-elements\"><input type=\"file\" name=\"" + this.options.paramName + "\" multiple=\"multiple\" /><button type=\"submit\">Upload!</button></div>");
       if (this.elementTagName !== "FORM") {
         fields = o("<form action=\"" + this.options.url + "\" enctype=\"multipart/form-data\" method=\"post\"></form>").append(fields);
+      } else {
+        if (!this.element.attr("enctype")) {
+          this.element.attr("enctype", "multipart/form-data");
+        }
+        if (!this.element.attr("method")) {
+          this.element.attr("method", "post");
+        }
       }
       return fields;
     };

diff --git a/downloads/dropzone.js b/downloads/dropzone.js
@@ -591,6 +591,13 @@ require.register("dropzone/lib/dropzone.js", function(exports, require, module){
       fields = o("<div class=\"fallback-elements\"><input type=\"file\" name=\"" + this.options.paramName + "\" multiple=\"multiple\" /><button type=\"submit\">Upload!</button></div>");
       if (this.elementTagName !== "FORM") {
         fields = o("<form action=\"" + this.options.url + "\" enctype=\"multipart/form-data\" method=\"post\"></form>").append(fields);
+      } else {
+        if (!this.element.attr("enctype")) {
+          this.element.attr("enctype", "multipart/form-data");
+        }
+        if (!this.element.attr("method")) {
+          this.element.attr("method", "post");
+        }
       }
       return fields;
     };

diff --git a/lib/dropzone.js b/lib/dropzone.js
diff --git a/src/dropzone.coffee b/src/dropzone.coffee
@@ -285,6 +285,10 @@ class Dropzone extends Em
     fields = o """<div class="fallback-elements"><input type="file" name="#{@options.paramName}" multiple="multiple" /><button type="submit">Upload!</button></div>"""
     if @elementTagName isnt "FORM"
       fields = o("""<form action="#{@options.url}" enctype="multipart/form-data" method="post"></form>""").append fields
+    else
+      # Make sure that the enctype and method attributes are set properly
+      @element.attr "enctype", "multipart/form-data" unless @element.attr "enctype"
+      @element.attr "method", "post" unless @element.attr "method"
     fields
 
   setupEventListeners: ->