Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dropzone message clickable #91

Merged
merged 1 commit into from
Apr 5, 2013
Merged

Make dropzone message clickable #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion downloads/css/stylus/basic.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

&.clickable
cursor pointer
.message
.message, .message span
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be necessary, should it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... yes it is. I just now realised that I've never experienced those problems because I always used the substitute image.

cursor pointer
*
cursor default
Expand Down
2 changes: 1 addition & 1 deletion src/dropzone.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ class Dropzone extends Em
"click": (evt) =>
return unless @options.clickable
# Only the actual dropzone or the message element should trigger file selection
if evt.target == @element or evt.target == @element.querySelector ".message"
if evt.target == @element or evt.target == @element.querySelector ".message" or evt.target == @element.querySelector ".message span"
@hiddenFileInput.click() # Forward the click


Expand Down