Fix Clippy diagnostics #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c410-f3r
commented
Feb 26, 2022
| @@ -108,23 +108,23 @@ macro_rules! array_refs { | |||
| use std::slice; | |||
| #[inline] | |||
| #[allow(unused_assignments)] | |||
| #[allow(eval_order_dependence)] | |||
| #[allow(clippy::eval_order_dependence)] | |||
There was a problem hiding this comment.
eval_order_dependence is deprecated
| unsafe fn as_arrays<T>(a: &[T]) -> ( $( &[T; $pre], )* &[T], $( &[T; $post], )*) { | ||
| let min_len = $( $pre + )* $( $post + )* 0; | ||
| let var_len = a.len() - min_len; | ||
| assert!(a.len() >= min_len); | ||
| let mut p = a.as_ptr(); | ||
| ( $( { | ||
| let aref = & *(p as *const [T; $pre]); | ||
| p = p.offset($pre as isize); | ||
| p = p.add($pre); |
There was a problem hiding this comment.
clippy::ptr_offset_with_cast is affecting downstream crates that use cargo clippy
Comment on lines
+477
to
+483
| #[forbid(clippy::ptr_offset_with_cast)] | ||
| #[test] | ||
| fn forbidden_clippy_lints_do_not_fire() { | ||
| let mut data = [0u8; 32]; | ||
| let _ = array_refs![&data, 8; .. ;]; | ||
| let _ = mut_array_refs![&mut data, 8; .. ; 10]; | ||
| } |
There was a problem hiding this comment.
Ensures that forbidden Clippy lints won't trigger again but I can remove it if you prefer so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.