Build: Better error handling and let git ignore temporary build directories. #183
Conversation
aknrdureegaesr
force-pushed
the
minor_build_improvements
branch
from
ecbbc87
to
2f804e6
Compare
|
The general C/C++ .gitignore template should be included in .gitignore too for those who want to build freedv-gui manually and not via the script. Also, it would be good to have the following for build_osx.sh: |
|
Thanks @aknrdureegaesr 🙂 @tmiw are your comments above something you would like to see in this PR, or more general issues for another PR? |
I figured it'd be good to include here since we're already touching .gitignore. However, it can go in another PR if preferred. |
The build_linux.sh scripts stops when encountering an error and reports what it is doing. Directories constructed temporarily during the build and files commonly constructed by the build ignored by git, as we do not want to version those. /usr/bin has become the official dwelling place of bash.
aknrdureegaesr
force-pushed
the
minor_build_improvements
branch
from
2f804e6
to
9033564
Compare
|
Looks good here 👍 |
|
At your service... Adding the directories was easy. I'm not entirely sure what a good C/C++ - template would be. So I checked which kind of files are actually created below Assuming you do not want to have several commits in the history, I replaced my previous commit with the new suggestion. |
|
@aknrdureegaesr, actually, several commits is no problem. Something for future reference. @drowe67, any additional comments or should I go ahead and merge? |
|
@tmiw I'm happy if you are 🙂 |
The
build_linux.shscript says what it is doing and stops when encountering an error.Directories that are constructed temporarily during the build
are now ignored by git, as we do not want to version those.
Ah, one more thing:
bashnow officially lives in/usr/bin, the/bindirectory is deprecated.Vy 73, Andreas, DJ3EI