Fix bug preventing 60 meter frequencies from using USB with DIGU/DIGL disabled #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not had time to test this PR but there is an occasional specific use case for using LSB on 60m in the UK, so 'forcing USB' would not be welcome. We do normally use USB. |
|
Yes, occasionally LSB is used to avoid the Olivia users on 5.3665MHz We could disable the red mode indication for this case, but that's really a minor issue. It is a useful reminder that USB is the expected mode on 60m. |
|
Yeah, USB is standard but this shouldn't prevent anyone from manually setting their radios to LSB as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug reported on the digitalvoice list where when "Use USB/LSB instead of DIGU/DIGL" is checked, the specific check to force USB for 60 meters is missing. This results in the radio improperly switching to LSB when a 60 meter frequency is selected or entered.