Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool tip Doesn't display on Hover #37

Closed
nirajkrz opened this issue Nov 15, 2018 · 3 comments
Closed

Tool tip Doesn't display on Hover #37

nirajkrz opened this issue Nov 15, 2018 · 3 comments

Comments

@nirajkrz
Copy link
Contributor

nirajkrz commented Nov 15, 2018

Hi,

Thanks for the great work on this tooltip. This is a life saver for many of us.

I have cloned this repo and tried to run it locally. On the rendered page, i do not get the tooltip on hover, It shows on click. Also the same behavior is seen when i include it in my project.

I have this as my options:
'animation-duration': 300, 'animation-duration-default': 300, 'trigger': 'hover', 'tooltip-class': '', 'display': true, 'display-mobile': true,

usage:
<div *ngIf="alertAvailble else noAlert" tooltip="Lorem ipsum dolor sit amet, his ut dicunt recteque ea." placement="top">some content here </div> <ng-template #noAlert>--</ng-template>

can you let me know what i am missing?

@nirajkrz nirajkrz changed the title Tool tip Doesn't open on Hover Tool tip Doesn't display on Hover Nov 15, 2018
@nirajkrz
Copy link
Contributor Author

There seems to be an issue with isDisplayOnHover in directive, I changed it to this for making it work as expected:

get isDisplayOnHover(): boolean {

                  if (this.options['trigger'] === 'hover') {
                   return true;
                  } else if (this.isMobile || this.options['display'] === false) {
                    return false;
              }
              return true;
   }`

@returnlytom
Copy link
Contributor

@nirajkrz Nice work, can you open a PR?

@nirajkrz
Copy link
Contributor Author

@returnlytom : sure will send it soon.

drozhzhin-n-e added a commit that referenced this issue Dec 11, 2018
fix for Tool tip Doesn't display on Hover #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants