Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build latest version #281

Open
popbangshwang opened this issue Dec 30, 2017 · 26 comments
Open

build latest version #281

popbangshwang opened this issue Dec 30, 2017 · 26 comments
Milestone

Comments

@popbangshwang
Copy link

Hello, just wondering if you would mind building the latest version, libdynticker seems to support binance already, just need to release a build of boilr with it.
It would be very much appreciated if you could.

Thanks in advance.

@dllud dllud modified the milestones: 0.9.0, 0.8.0 Dec 30, 2017
@gitowok
Copy link

gitowok commented Jan 9, 2018

@dllud - is this a simple case of putting together a build environment and building from latest master branch, or would there be changes required to the gui to enable binance and newer exchanges from libdynticker?

@dllud
Copy link
Member

dllud commented Jan 9, 2018

No changes required. It's all on the master branch already. I just need to release a proper build. I didn't find the time yet.

@gitowok
Copy link

gitowok commented Jan 9, 2018

awesome.

@gitowok
Copy link

gitowok commented Feb 16, 2018

Well I spent a few hours today trying to get my head around maven and the android SDK from cold, but I'm throwing in the towel as i have no idea what i'm doing without probably another 5+ more hours. This is beyond my threshold of pain, for a once off task of "build the project and give people an APK link".

@dllud - pretty pretty please - hit compile for us?

@dllud
Copy link
Member

dllud commented Feb 16, 2018

@gitowok I will try to build it this weekend. Sorry for the delay. It's not just a matter of hitting a button. Many more task have to be done, hence I have to get an entire free day for this.

@gitowok
Copy link

gitowok commented Apr 12, 2018

another friendly bump.. binance and kucoin are heavily used now, both missing from boilr. Cheers

@dllud
Copy link
Member

dllud commented Apr 12, 2018

Thanks for the reminder. I am aware. It will be done sooner rather than later.

@gitowok
Copy link

gitowok commented Jul 18, 2018

I still check every weekend! :)

@dllud
Copy link
Member

dllud commented Jul 18, 2018

Thanks for keeping up and sorry for the long delay. I will let you know here as soon as I release a new build. It's just that spare time has been so scarce…

@Eimuex
Copy link

Eimuex commented Feb 14, 2019

Hello, does it means that if I build apk from master source I will have binance? I don't know how to do it but I'll give it a try if that's the case.

@gitowok
Copy link

gitowok commented Feb 15, 2019

Yes. Please post your APK! good luck, i couldnt work it out.

@Eimuex
Copy link

Eimuex commented Feb 15, 2019

I'm stuck with this error:
[ERROR] Failed to execute goal com.simpligility.maven.plugins:android-maven-plugin:4.5.0:generate-sources (default-generate-sources) on project boilr: Execution default-generate-sources of goal com.simpligility.maven.plugins:android-maven-plugin:4.5.0:generate-sources failed: A required class was missing while executing com.simpligility.maven.plugins:android-maven-plugin:4.5.0:generate-sources: javax/xml/bind/annotation/XmlSchema

EDIT: simpligility/android-maven-plugin#778
Successfully done with jdk8

@Eimuex
Copy link

Eimuex commented Feb 16, 2019

I managed to build boilr 0.8.0-rc2 debug apk with libdynticker-0.8.0, but still binance is not shown as choice inside the app. It’s listed inside libdynticker-0.8.0.jar though.

@dllud
Copy link
Member

dllud commented Feb 16, 2019

Thanks for the effort @Eimuex ! Yes, it needs to be added to the exchanges lists in Boilr. I am doing that this weekend.

@Eimuex
Copy link

Eimuex commented Feb 16, 2019

@dllud Cool, I have compiled libdynticker jars if you need them, but had to skip some tests due to offline exchanges, don't know if that matters.

@gitowok
Copy link

gitowok commented Feb 17, 2019

woo.. keep this momentum going guys! @dllud - in case you dont get time, could you give Eimuex some pointers on which file to modify for adding binance?

@Eimuex
Copy link

Eimuex commented Feb 17, 2019

Yes please. I tried to find relevant lists without success. If you are over-occupied I could try to make it work, though I’m not programmer and probably can’t deal with complex stuff.

@Eimuex
Copy link

Eimuex commented Feb 20, 2019

I compiled printexchanges with mvn compile exec:java -P xml and got classes folder without xml. Don't know how to include it into boilr.

@gitowok
Copy link

gitowok commented Feb 22, 2019

@Eimuex - well done re compiling. If you have time can you document rough steps to set up the build environment? I'd like to give it another go myself. Also, does bitmex exchange work on your compiled version? (it was already in old version just not working)

@Eimuex
Copy link

Eimuex commented Feb 22, 2019

I installed jdk-8 and android sdk 28 first.
Then compiled libdynticker and placed jar and pom into /home/user/.m2/repository/mobi/boilr/libdynticker/0.8.0 .
After that I exported paths for sdk and followed steps from https://github.com/drpout/boilr to compile bolir (in step 3 I used ‘android-28’ instead of 26). Also I used ‘debug’ cause I don’t know how to sign apk.
Bitmex is working on this version as I can see.

@Eimuex
Copy link

Eimuex commented Feb 28, 2019

@gitowok Any luck?

@gitowok
Copy link

gitowok commented Apr 26, 2019

Hi all. I finally got around to this. Thanks to the great instructions from @Eimuex - and a bit of extra problem solving (had to install the Android 8.0 (API 26) using android sdk manager to get rid of a NullPointerException in findPlatformByApiLevel / android-maven-plugin - even though I specified Android-28 in step 3)

The file to edit before building to get binance support: src/main/res/values/strings_no_translate.xml

Just add "Binance" and "mobi.boilr.libdynticker.exchanges.BinanceExchange" to the relevant lists.

And finally, here's my APK: https://www.jabawok.net/uploads/fixes/boilr-0.8.0-rc2-binance.apk

I really hope this helps someone, and big props to @dllud for work on this excellent app. May we encourage you to do an official build and deploy to f-droid !

@dllud
Copy link
Member

dllud commented Apr 26, 2019

Glad to know you were able to build it!

And thanks for the push. Encouragement is not lacking, it is rather a chronic lack of free time. But I will get into it.

@algazarra
Copy link
Member

Awesome! Great work

@Eimuex
Copy link

Eimuex commented Apr 27, 2019

@gitowok Great man, thank you!

@gitowok
Copy link

gitowok commented Mar 8, 2020

I still use this dodgy custom build with bitmex and binance support every day. Its still the only thing with price alarms in f-droid. @dllud - just some more encouragement to spend a couple hours and bump the f-droid version. cheers man.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants