Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup for LLVM compilers #51

Merged
merged 5 commits into from
May 17, 2024
Merged

Code cleanup for LLVM compilers #51

merged 5 commits into from
May 17, 2024

Conversation

drsteve
Copy link
Owner

@drsteve drsteve commented May 10, 2024

Main items in clean-up:

@JeffreyBroll
Copy link

Looks good to me - I just keep forgetting that _qpInfo is int... README changes also great

@JeffreyBroll
Copy link

It built fine with clang and gcc. I don't have tests to run off the top of my head, but there's nothing in Lgm_SummersDiffCoeff that isn't what was implicitly done so that should be fine.

@drsteve
Copy link
Owner Author

drsteve commented May 10, 2024

Thanks! The CI builds with GCC (although that worked before these changes), and I've built with cce-clang. I'll wait for Sean's feedback and then merge.

@drsteve drsteve merged commit 620dcd5 into master May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants