Remove go-bindata, use go:embed, use Go Modules #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your help and I'm happy my tool helps you out as well. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there;
With the prevalence of Go Modules, I'm submitting a patch to enable Certinel to use Go Modules, which will make it easier for users to install Certinel.
In the same theme, I've also removed the dependency on go-bindata since there's been some bad history there of the repo getting deleted, then taken over by another GitHub user, etc... Go 1.16 now supports the
go:embeddirective which allows for native embedding of static assets, so this vastly simplifies the steps necessary to compile.Still a big fan of Certinel after all these years! Thanks for the awesome tool!
Cheers,
Ty