Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit bbd5836 breaks compatibility in Plan with other FactionsUUID forks #1429

Closed
AuroraLS3 opened this issue Jul 3, 2021 · 2 comments
Closed

Comments

@AuroraLS3
Copy link

Logs

bbd5836

java.lang.NoSuchMethodError: 'com.massivecraft.factions.util.TL com.massivecraft.factions.perms.Role.getTranslation()'
   com.djrapitops.extension.FactionsUUIDExtension.role(FactionsUUIDExtension.java:131)
   java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
   java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   java.base/java.lang.reflect.Method.invoke(Method.java:567)
   com.djrapitops.plan.extension.implementation.providers.Parameters$PlayerParameters.usingOn(Parameters.java:97)
   com.djrapitops.plan.extension.implementation.providers.MethodWrapper.callMethod(MethodWrapper.java:50)
   com.djrapitops.plan.extension.implementation.providers.gathering.DataValueGatherer.callMethod(DataValueGatherer.java:288)
   com.djrapitops.plan.extension.implementation.providers.gathering.DataValueGatherer.lambda$tryToBuildString$2(DataValueGatherer.java:193)
   com.djrapitops.plan.extension.implementation.builder.BuiltDataValue.getValue(BuiltDataValue.java:48)
   com.djrapitops.plan.extension.implementation.providers.gathering.DataValueGatherer.getValue(DataValueGatherer.java:391)
   com.djrapitops.plan.extension.implementation.providers.gathering.DataValueGatherer.storePlayerString(DataValueGatherer.java:497)
   com.djrapitops.plan.extension.implementation.providers.gathering.DataValueGatherer.lambda$gatherPlayer$14(DataValueGatherer.java:328)
   java.base/java.util.Optional.ifPresent(Optional.java:178)
   com.djrapitops.plan.extension.implementation.providers.gathering.DataValueGatherer.gatherPlayer(DataValueGatherer.java:328)
   com.djrapitops.plan.extension.implementation.providers.gathering.DataValueGatherer.updateValues(DataValueGatherer.java:302)
   com.djrapitops.plan.extension.ExtensionSvc.updatePlayerValues(ExtensionSvc.java:169)
   com.djrapitops.plan.extension.ExtensionSvc.updatePlayerValues(ExtensionSvc.java:156)
   com.djrapitops.plan.gathering.listeners.bukkit.PlayerOnlineListener.lambda$actOnJoinEvent$4(PlayerOnlineListener.java:201)
   com.djrapitops.plan.processing.Processing.lambda$submitNonCritical$1(Processing.java:78)
   java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1764)
   java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
   java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
   java.base/java.lang.Thread.run(Thread.java:831)

Details

bbd5836#diff-db53124765195a4131a41e5d57ae046827ebea0251832f0efd9a09a73938d0c2L87 Change breaks use of Role#getTranslation in my plugin which expects this method to return TL

https://github.com/plan-player-analytics/Extension-FactionsUUID/blob/master/src/main/java/com/djrapitops/extension/FactionsUUIDExtension.java#L131

I can't really change this to use String because it would break compatibility with other FactionsUUID forks

@mbax
Copy link
Collaborator

mbax commented Jul 3, 2021

plan-player-analytics/Extension-FactionsUUID#2

@mbax
Copy link
Collaborator

mbax commented Jul 3, 2021

PR is now merged. Hoping this resolves it. :)

@mbax mbax closed this as completed Jul 3, 2021
AuroraLS3 added a commit to plan-player-analytics/Plan that referenced this issue Jul 3, 2021
- mbax Fixes incompatibility with new FactionsUUID
- Added mbax as Code contributor

Affects issues:
- Fixed drtshock/Factions#1429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants