Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in IE8 and IE9+ #169

Closed
Komald opened this issue Dec 2, 2014 · 8 comments
Closed

Not working in IE8 and IE9+ #169

Komald opened this issue Dec 2, 2014 · 8 comments
Labels
Milestone

Comments

@Komald
Copy link

Komald commented Dec 2, 2014

Hello There,

I am facing a situation for IE browser all versions. I am having a link to open a modal and another link on that modal to close current modal and open another one. This works perfectly well in rest of the leading browsers, but fails in IE. The processes executes well till opening first modal, but when I click link to open another modal, the first one closes (as expected) but does not opens the second.

Here is the fiddle link
http://jsfiddle.net/seyfso6L/

Hope this will help to understand the issue. Please have a look.

Thanks,
-Komal

@drublic
Copy link
Owner

drublic commented Dec 2, 2014

Thanks for reporting, @Komald. We will look into this issue asap.

@drublic drublic added this to the v1.3.0 milestone Dec 2, 2014
@drublic drublic added the bug label Dec 2, 2014
@drublic
Copy link
Owner

drublic commented Dec 2, 2014

Just saw that this demo is using v1.0.1. Can you please check with 1.2.0 https://github.com/drublic/css-modal/blob/master/build/modal.css ?

@Komald
Copy link
Author

Komald commented Dec 2, 2014

I tried by replacing the css and js with v1.2 but that wont work. Instead it disturbed the design completely. I don't know if I did this correct, but you can have a look
http://jsfiddle.net/komalAD/seyfso6L/1/

@drublic
Copy link
Owner

drublic commented Dec 2, 2014

That's just a problem with the wrong class: modals need .modal--show http://jsfiddle.net/seyfso6L/2/

@Komald
Copy link
Author

Komald commented Dec 3, 2014

Ok, I checked it, but still its not working as expected. If I click on Forgot Password then it should close the existing Sign In modal and open the Forgot Password modal. just I said the initial fiddle works for all browsers except IE. is it possible to do something on that script and start working on IE too?

@drublic
Copy link
Owner

drublic commented Jan 7, 2015

So I've checked this again.

Currently the second modal opens "stacked" above the first one. This happens in IE9 and Chrome for me.
If you don't want this behavior, but want to open the first, then click, (close the first), open the second, close the second and be back at the page without any modal you might want to add data-stackable="false" to the second modal's section element.

Edit: Stackable modals don't seem to work according to my tests at the moment. I'll take care of this.

@drublic
Copy link
Owner

drublic commented Jan 7, 2015

Stackable modals should be fixed now.

@drublic
Copy link
Owner

drublic commented Jan 12, 2015

Closing this now. Please let me know if you have any problems with it.

@drublic drublic closed this as completed Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants