IE10 on Win7 not showing transition

[impressivewebs]

I don't see a transition happening when the modal opens on IE10. I suspect it's the same problem described here:

http://stackoverflow.com/questions/17576236/ie10-win-7-ignores-css-keyframes-when-within-a-media-query

The transition is inside a media query, and that's the only thing I can think of that would cause it not to work.

[anselmh]

You need to move the @keyframes sections outside the @media section because IE10 gets mixed up by the 'nested @'. The call to keyframes can stay there.

Interesting but this isn't our problem. It is simply we are not using the -ms- prefix in the transition. Thanks for reporting, we will fix this soon. For now simply add in before line 319 (https://github.com/drublic/css-modal/blob/master/modal.scss#L319) a -ms-transition: opacity 0.4s;.

[impressivewebs]

No, I don't think that's going to work. IE10 supports transitions without the prefix, so that is a non-issue, as far as I can tell. I've slapped together a quick version on JS Bin, which I've tested on IE10:

http://jsbin.com/atituzA/1/edit

It still doesn't show the transition in IE10, even after I add -ms-. If you want, when I get some time, I can try to debug it, because I know it should work as long as the transition is put in the right place in the code, without the prefix.

[impressivewebs]

(sorry I originally pasted the wrong JS Bin link, corrected now)

[anselmh]

Well, it would be awesome if you could look into it and report (or maybe send a PR rearding this on v1.1). :)

[impressivewebs]

Sure, I'll see what I can do. If someone has a reduced test case ready, that would be nice for me to start with, but I could just strip down the JS Bin I created and go from there.

[drublic]

Louis, you can just use the index.html file in branch wip-1.1.0. It has all modal styles we use.

On 18.09.2013, at 08:22, Louis Lazaris notifications@github.com wrote:

Sure, I'll see what I can do. If someone has a reduced test case ready, that would be nice for me to start with, but I could just strip down the JS Bin I created and go from there.

—
Reply to this email directly or view it on GitHub.

[anselmh]

This works fine in my tests in IE10, 11 under WIN7 + WIN 8 with both, v1.0 and v1.1. Therefore closing this now.