Separating Sass code into core, theme and config modules #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I separated the Sass code into 3 separate files for easier look and feel updates.
_modalConfig.scss
_modalCore.scss
_modalTheme.scss
I'm using the plugin for our current project and the only downside was how the look and feel was tied to the core styles.
This has helped me since the theme styles are separated from the core and the risk of breaking the functionality is reduced.
The only actual change is removing the BG data image which I replaced with CSS styles to allow customization.
Replaced:
With:
Feel free to ignore if this is not going in the direction you want!