Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide access to router within web container by hostname, fixes #842 #1151

Merged
merged 6 commits into from Oct 4, 2018

Conversation

rfay
Copy link
Member

@rfay rfay commented Oct 2, 2018

The Problem/Issue/Bug:

Various web projects require http/s access to the project by the projects scheme/name/port from within the web container, which means they have to go through the router. OP #842

How this PR Solves The Problem:

Provide access to the router using docker-compose.yaml

Manual Testing Instructions:

  • Start a project
  • ddev ssh
  • Use curl <fqdn> to view the project.

For extra credit, use the https URL and use configurable ports. For https you'll need to use curl -k.

Automated Testing Overview:

  • Added TestInternalAndExternalAccessToURL(). This tests external and internal url access with a content test and also tests with nonstandard ports
  • Reorganized site definition to not only get a safe static URL to hit but also check the returned content.

Related Issue Link(s):

OP #842

Release/Deployment notes:

@rfay rfay self-assigned this Oct 2, 2018
@rfay rfay requested a review from andrewfrench October 2, 2018 21:46
@rfay rfay changed the title Provide access to router by hostname, fixes #842 Provide access to router within web container by hostname, fixes #842 Oct 2, 2018
@rfay rfay added the needs docs label Oct 3, 2018
@rfay
Copy link
Member Author

rfay commented Oct 3, 2018

This requires documentation for various external services that may want to access the web container by URL.

Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to configure an FQDN, ddev start, ddev ssh, curl <fqdn>, and run ping <fqdn>. Curl returned the local d7 install page as expected, and the FQDN resolved to localhost through ping.

@rfay rfay merged commit 3b72bca into ddev:master Oct 4, 2018
@rfay rfay deleted the 20181002_support_hostname_inside_container branch October 4, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants