Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-depth testing of sites to ddev tests #677

Closed
4 tasks
rfay opened this issue Feb 24, 2018 · 5 comments
Closed
4 tasks

Add in-depth testing of sites to ddev tests #677

rfay opened this issue Feb 24, 2018 · 5 comments
Assignees
Milestone

Comments

@rfay
Copy link
Member

rfay commented Feb 24, 2018

What happened (or feature request):

In our tests we have a variety of CMSs that we install and start ddev.... but we don't actually do anything with the sites after starting, just test ddev functions like import-db and the like. For real test coverage we need to verify:

  • Hitting the front page works
  • Logging in works
  • Visiting some important URLs works
  • Imagecache/image styles or the equivalent work properly

We'll need to add to this list as we go.

What you expected to happen:

How to reproduce this:

Version: Please include the output of ddev version, docker version and the project's .ddev/config.yaml.

Anything else do we need to know:

Related source links or issues:

Please use a complexity rating of 1-5 (5 is high) for a feature request. (High complexity implies more PR planning)

@cweagans
Copy link
Contributor

I've been using https://github.com/headzoo/surf on a personal project with a decent amount of success. Might be useful here.

@rickmanelius
Copy link
Contributor

I'm not sure if this was already addressed in #671. Seems useful and will pin to v1.2.0 as a milestone related to CMS support.

@rfay
Copy link
Member Author

rfay commented Mar 26, 2018

No, this was a spin-off from #671 - We've never had any nontrivial tests for the test sites we install, and it will really improve our coverage and detection when we add them.

@dclear dclear removed this from the v1.2.0 milestone May 17, 2018
@rfay
Copy link
Member Author

rfay commented Jun 1, 2018

These should probably be spun off into separate tickets.

When doing Wordpress, please work closely with @alkymst to do something reasonable there.

@rfay
Copy link
Member Author

rfay commented Oct 3, 2018

So the way I'm thinking about this now is pretty easy to implement.

  1. After Provide access to router within web container by hostname, fixes #842 #1151 lands, it adds a URI+Expectation.
  2. Add a non-static expectation URL (or array of expectations?) to the TestSite type
  3. In TestDdevImportDB, test appropriate expected URLs for each project.

I think that's all we really have to do. Not very ambitious at all.

@rfay rfay assigned rfay and unassigned andrewfrench Oct 3, 2018
rfay added a commit to rfay/ddev that referenced this issue Oct 4, 2018
rfay added a commit to rfay/ddev that referenced this issue Oct 6, 2018
rfay added a commit to rfay/ddev that referenced this issue Oct 6, 2018
rfay added a commit to rfay/ddev that referenced this issue Oct 8, 2018
rfay added a commit to rfay/ddev that referenced this issue Oct 8, 2018
@rfay rfay closed this as completed in 93d0039 Oct 8, 2018
@dclear dclear removed the actionable label Oct 13, 2018
@dclear dclear added this to the v1.3.0 milestone Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants