Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We no longer have to cleanup the temp dir as it's cleaned up in the body, fixes #1457 #1486

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

rfay
Copy link
Member

@rfay rfay commented Mar 6, 2019

The Problem/Issue/Bug:

OP #1457 reported a warning (it turned out to be only a warning) that the temp directory on ddev composer create was not being deleted. It turns out that we had actually improved the code that moves everything, so it was no longer necessary to do the cleanup at all.

How this PR Solves The Problem:

Remove the obsolete code, and the defer that called it.

Manual Testing Instructions:

mkdir junk && cd junk
ddev composer create --prefer-dist --no-interaction --no-dev psr/log 1.1.0
  • You should not see a warning about failing to remove
  • ls -a should show no leftover .tmp directory

Automated Testing Overview:

Related Issue Link(s):

OP #1457

@rfay rfay requested a review from andrewfrench March 6, 2019 00:44
@rfay rfay self-assigned this Mar 6, 2019
@rfay rfay added this to the v1.6.1 milestone Mar 6, 2019
Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the original issue (the erroneous warning), that this change prevents it, and that the temp directory is cleaned up by the existing process. Good catch, sorry for not noticing this!

@rfay rfay merged commit 58ecdf1 into ddev:master Mar 6, 2019
@rfay rfay deleted the 20190305_fix_ddev_composer_install_fail branch March 6, 2019 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants