We no longer have to cleanup the temp dir as it's cleaned up in the body, fixes #1457 #1486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
OP #1457 reported a warning (it turned out to be only a warning) that the temp directory on
ddev composer create
was not being deleted. It turns out that we had actually improved the code that moves everything, so it was no longer necessary to do the cleanup at all.How this PR Solves The Problem:
Remove the obsolete code, and the defer that called it.
Manual Testing Instructions:
ls -a
should show no leftover .tmp directoryAutomated Testing Overview:
Related Issue Link(s):
OP #1457