Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing php-pgsql packages to ddev-webserver container #1514

Merged
merged 2 commits into from Apr 9, 2019

Conversation

dacostafilipe
Copy link
Contributor

The Problem/Issue/Bug:

There are configuration files for posgres support in the ddev-webserver container, but the php*-pgsql packages are missing.

How this PR Solves The Problem:

Updates the Dockerfile to install the needed php*-pgsql packages.

Manual Testing Instructions:

To test if pgsql is loaded, you can run php --info | grep pgsql in the container.

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2019

CLA assistant check
All committers have signed the CLA.

@dacostafilipe dacostafilipe changed the title Install php*-pgsql when creating the image Add missing php-pgsql packages to ddev-wevserver container Mar 29, 2019
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks! I took the liberty of pushing up drud/ddev-webserver:feature-pgsql-support to dockerhub, and bumping the built-in tag.

@rfay rfay changed the title Add missing php-pgsql packages to ddev-wevserver container Add missing php-pgsql packages to ddev-webserver container Mar 30, 2019
@rfay rfay merged commit ce86166 into ddev:master Apr 9, 2019
@ndq1 ndq1 mentioned this pull request Apr 19, 2019
@rfay rfay mentioned this pull request May 9, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants