Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in comments #3399

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Fixed typos in comments #3399

merged 2 commits into from
Nov 30, 2021

Conversation

stasadev
Copy link
Member

No description provided.

@rfay
Copy link
Member

rfay commented Nov 25, 2021

You're at it again! Very impressive!

@stasadev
Copy link
Member Author

You are welcome!
It was a run through all project files 🙂

@rfay
Copy link
Member

rfay commented Nov 25, 2021

All my classic typos, like "WIndows"

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great, thanks for the hard work here (and good tools).

I noted a couple of places where it makes no sense to be editing the test code, but does no harm, and thus your tools won't stumble on it next time.

@@ -234,7 +234,7 @@ Drupal.ahah.prototype.success = function (response, status) {
*/
Drupal.ahah.prototype.error = function (response, uri) {
alert(Drupal.ahahError(response, uri));
// Resore the previous action and target to the form.
// Restore the previous action and target to the form.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actual Drupal 6 code, no need to be correcting it here. Not that it matters.

Suggested change
// Restore the previous action and target to the form.
// Resore the previous action and target to the form.

@@ -246,7 +246,7 @@ Drupal.ahah.prototype.error = function (response, uri) {
// Undo hide.
$(this.wrapper).show();
// Re-enable the element.
$(this.element).removeClass('progess-disabled').attr('disabled', false);
$(this.element).removeClass('progress-disabled').attr('disabled', false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this is actual Drupal 6 code, no need to correct. I wonder if this bug was ever fixed.

@@ -510,7 +510,7 @@ Drupal.ajax.prototype.commands = {
var effect = ajax.getEffect(response);

// We don't know what response.data contains: it might be a string of text
// without HTML, so don't rely on jQuery correctly iterpreting
// without HTML, so don't rely on jQuery correctly interpreting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual Drupal 7 code. Does no harm to fix here, but irrelevant.

@rfay rfay merged commit 3e7b8aa into ddev:master Nov 30, 2021
@stasadev stasadev deleted the support/fix_typos branch December 1, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants