fixes list and workon for site names containing dashes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just reading through this, it seems "OK", but do we actually need to parse our own container to figure out what it contains? Is there any other way we could do that? It seems like we ought to have a much easier way to figure out what it is we have. |
|
Could possibly achieve that via container labels. |
|
labels could work, and seems like a reasonable effort. I'll see where it goes. |
tannerjfco
changed the title
|
Please update the OP with the new strategy for resolving, explaining exactly the approach you've taken with labels and any implications of that. I've just taken a scan through the code, but will finish my review when the internet works again. Thanks! |
beeradb
reviewed
Feb 28, 2017
| labels: | ||
| com.drud.site-name: {{ .site_name }} | ||
| com.drud.site-env: {{ .site_env }} | ||
| com.drud.container-type: db |
There was a problem hiding this comment.
So glad you added these too.
beeradb
approved these changes
Mar 1, 2017
mootari
added a commit
to mootari/ddev
that referenced
this pull request
Sep 9, 2021
Fixes breaking readthedocs builds due to removal of Python 2 support in setuptools 58. PR: tikitu/jsmin#34
rfay
pushed a commit
that referenced
this pull request
Sep 9, 2021
Fixes breaking readthedocs builds due to removal of Python 2 support in setuptools 58. PR: tikitu/jsmin#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem:
#30 -
ProcessContainer()processed the container name by splitting into a slice by dashes. This approach doesn't work if the site name contains a dash.The Fix:
This implements docker labels to provide the data we're after for
dev listin a cleaner way.This also updates the string parsing in
dev workonto more reliably separate site name and environment.Both fixes should allow ddev to handle sitenames containing dashes successfully.
The Test:
drud-d8 production.ddev listand see the site listed as expectedAutomation Overview:
I updated the primary test app to be
drud-d8, one of the sites containing a dash in the name. That's really all that's needed to validate this fix.Related Issue Link(s):
#30
Release/Deployment notes:
Does this affect anything else, or are there ramifications for other code? Does anything have to be done on deployment?
This should address the remaining test issues currently in #24