Updates endpoint for web container readiness check #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem:
#66 original issue desc. We need to reliably determine if the web container is ready to serve.
The Fix:
This updates to check the new
/healthcheck
endpoint added to the nginx containers, rather than the root of the user's web application. This will allow us to determine container readiness regardless of the web app's state.This also restores the Wait() in the start cmd, and updates restart to remove Config(), as that should have been removed.
The Test:
Automation Overview:
The local plugin tests have been adjusted to include Wait() in TestLocalStart() and TestLocalRemove().
Related Issue Link(s):
#66
drud/docker.nginx-php-fpm#33
drud/docker.nginx-php-fpm-local#7
Release/Deployment notes:
Does this affect anything else, or are there ramifications for other code? Does anything have to be done on deployment?
These PRs are part of this change:
drud/docker.nginx-php-fpm#33
drud/docker.nginx-php-fpm-local#7
Provisional tags for
v0.3.1
have been pushed to dockerhub. Upon merge in both repos, a newv0.3.1
release should be tagged.