Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EvaluationTask should NOT fail if external task fails or is killed #129

Closed
coleslaw481 opened this issue Mar 23, 2017 · 1 comment
Closed

EvaluationTask should NOT fail if external task fails or is killed #129

coleslaw481 opened this issue Mar 23, 2017 · 1 comment
Assignees
@coleslaw481
Labels
bug
Milestone
1.7.1

Comments

@coleslaw481
Copy link
Contributor

Modify EvaluationTask in evaluation.py to not fail if the external evaluate script fails or is killed. This can be easily fixed by setting the third flag in run() method self.run_external_command to False instead of True.

Reason for this change is autodock evaluation exceeded the time limit and was killed which resulted in a non zero exit code. This is fine, but celpprunner.py saw the failed task so it exited and did NOT run postevaluation.
@coleslaw481 coleslaw481 added this to the 1.7.1 milestone Mar 23, 2017
@coleslaw481 coleslaw481 self-assigned this Mar 23, 2017
coleslaw481 added a commit that referenced this issue Mar 23, 2017
@coleslaw481
fix for issue #129 evaluationtask should NOT fail if call to external…
f2148d1 
… evaluation.py script returns a non zero exit code
@coleslaw481
Copy link
Contributor Author

Fixed by switching boolean from True to False in run_external_command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleslaw481 coleslaw481

Labels
bug
Projects
None yet
Milestone
1.7.1
Development

No branches or pull requests
1 participant
@coleslaw481