Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to modify post_evaluation.py to output lines in summary about failed evaluations #130

Closed
coleslaw481 opened this issue Mar 23, 2017 · 1 comment
Assignees
Milestone

Comments

@coleslaw481
Copy link
Contributor

If an evaluation fails and does NOT have a pickle file, post_evaluation.py will NOT output anything about that evaluation in summary.txt or the CSV files. This should be changed to report the failure of that evaluation.

To fix _get_pickle_paths should be modified to output a tuple with the second value being a list of the evaluations that are missing pickle files instead of just a count of those. Then generate_overall_csv() first needs to be adjusted to handle the adjustment to the return of _get_pickle_paths() and after the pickle file loop any evaluations without pickle files should be output as lines with NA lines for values to denote a problem.

@coleslaw481 coleslaw481 added this to the 1.7.1 milestone Mar 23, 2017
@coleslaw481 coleslaw481 removed this from the 1.7.1 milestone Mar 23, 2017
@coleslaw481 coleslaw481 changed the title Need to modify post_evaluation.py to handle output lines in summary about failed evaluations Need to modify post_evaluation.py to output lines in summary about failed evaluations Mar 23, 2017
@coleslaw481 coleslaw481 added this to the 1.8.1 milestone May 18, 2017
@coleslaw481 coleslaw481 self-assigned this May 18, 2017
@coleslaw481 coleslaw481 modified the milestones: 1.9.0, 1.10.0 Jun 23, 2017
coleslaw481 added a commit that referenced this issue Dec 22, 2017
…issing pickle files and updated generate_overall_csv() to handle this
@coleslaw481
Copy link
Contributor Author

Updated _get_pickle_paths() to return a list of missing entries. Still not done cause generate_overall_csv() is basically just using len on missing list entries to work the same as before.

coleslaw481 added a commit that referenced this issue Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant