Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download new tsv file in data import stage #84

Closed
coleslaw481 opened this issue Sep 26, 2016 · 5 comments
Closed

Download new tsv file in data import stage #84

coleslaw481 opened this issue Sep 26, 2016 · 5 comments
Assignees
@coleslaw481
Labels
enhancement
Milestone
1.6.0

Comments

@coleslaw481
Copy link
Contributor

coleslaw481 commented Sep 26, 2016 •
edited

Although not official yet, but odds are this file will need to be downloaded in the data import task. Before working on this task.

File to download:
http://wwpdb.org/files/new_release_structure_sequence_canonical.tsv
@coleslaw481
Copy link
Contributor Author

Shuai let me know if you want this new tsv file downloaded

@shuail
Copy link
Collaborator

shuail commented Sep 27, 2016

Hi Chris, yes let's use the new "canonical" file. Thanks!

@shuail shuail closed this as completed Sep 27, 2016
@coleslaw481 coleslaw481 reopened this Sep 28, 2016
@coleslaw481 coleslaw481 assigned coleslaw481 and unassigned shuail Sep 28, 2016
@coleslaw481
Copy link
Contributor Author

Going to make this change.

@coleslaw481 coleslaw481 added this to the 1.6.0 milestone Sep 28, 2016
coleslaw481 added a commit that referenced this issue Sep 28, 2016
@coleslaw481
untested fix for issue #84. replace data import SEQUENCE_TSV value an…
7eec32b 
…d set it to new_release_structure_sequence_canonical.tsv instead of new_release_structure_sequence.tsv
@coleslaw481
Copy link
Contributor Author

Committed untested fix:
8c82b98..7eec32b chrisdev -> chrisdev

DataImportTask has new method get_oldsequence_tsv() and DataImportTask also downloads old and new sequence tsv. BlastNFilterTask now checks for sequence.tsv file and if it does not exist it falls back to old sequence tsv.

@coleslaw481
Copy link
Contributor Author

Merged changes into master

coleslaw481 added a commit that referenced this issue Oct 5, 2016
@coleslaw481
added issue #84 to list of changes in 1.6.0
53798b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleslaw481 coleslaw481

Labels
enhancement
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@coleslaw481 @shuail